<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"></p>
<div>projects/compiler-rt/lib/builtins/clear_cache.c</div>
<div><br>
</div>
<div>I suggest two small changes here.</div>
<div><br>
</div>
<div>1. Mark it however required to avoid inlining, i.e. for the x86/amd64 case.</div>
<div>Control transfer is required. I realize it is likely anyway, you aren't likely</div>
<div>to "fall from" the caller into the code.</div>
<div><br>
</div>
<div>2. #elif defined(_WIN32) && (defined(__arm__) || defined(__aarch64__))</div>
<div>be changed to just:</div>
<div>#elif defined(_WIN32)</div>
<div><br>
</div>
<div>since Win32 hypothetically/historically runs on more than just x86/amd64/arm/arm64, and</div>
<div>FlushInstructionCache has been and presumably will remain omnipresent.</div>
<div></div>
<div><br>
</div>
<div></div>
- Jay
<p></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature"><br>
</div>
</div>
</body>
</html>