[llvm-dev] [RFC] Generate Debug Information for Labels in Function

[Adrian Prantl via llvm-dev]

> On Apr 1, 2018, at 9:12 AM, Hsiangkai Wang <hsiangkai at gmail.com> wrote:
> 
> Hi all,
> 
> I am sorry that I didn’t carefully think about how to handle labels in
> inlined function.

There is no need to apologize! Thank you very much for engaging in the discussion and for contributing you patches.
> 
> Today, I did some simple experiments and found that some basic block
> may be removed in CFGSimplifyPass and the attached metadata will be
> eliminated. So, if the optimization is turned on, label metadata will
> disappear. However, intrinsic will keep existing in the function if we
> handle it correctly. So, if we take care about optimization and
> inlining, to keep label metadata through intrinsic could be right for
> free.
> 
> I learned a lot from discussions. Thanks for your comments and
> suggestions. If there is no other concern, I will keep my original
> implementation and send patches to Phabricator again.

That sounds like a good plan.

-- adrian