[llvm-dev] RFC: AArch64 SVE Assembler/Disassembler patches

Renato Golin via llvm-dev llvm-dev at lists.llvm.org
Fri Oct 20 13:39:49 PDT 2017


On 19 October 2017 at 17:58, Florian Hahn via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> I think it would be good to give a description/explanation of the change in
> the review description.

+1, it's really hard to understand the intention just by the title.

A few tips:
 - Add links between the patchs in phab, helps review the whole series
in one go. (Edit Related Revisions).
 - Describe what the single patch does. If there are things that it
should do but are in another patch, mention that.
 - In the first patch, you can be a bit more creative. Describe what
the series do in addition to the first one. Add the following patches
numbers in the comments, too, so people can click directly at the
header.

cheers,
--renato


More information about the llvm-dev mailing list