[llvm-dev] de-posixifying list tests?

[Kostya Serebryany via llvm-dev]

Rafael, Filipe,

I am looking at the fixes you apply to sanitizer tests and they worry me.
(e.g. https://reviews.llvm.org/D31498)
The fixes are mostly mechanical and thus every single change looks safe,
but given the amount of changes there is large risk to cripple some of the
tests
in a way that they will stop detecting failures.

When I write a test for new functionality, I always verify that the test
fails w/o the implementation
of that functionality (i.e. that the test catches the failure). I hope most
of the tests are developed this way too. But when you modify the tests, I
bet you only verify that the passing test is still passing. Am I right? If
yes, this is not the way to modify tests, unfortunately.

So, my question is: did you consider modifying the environment to closer
match what already works well on posix, instead of massively changing
tests?

Thanks,

--kcc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170330/3a974136/attachment-0001.html>