[llvm-dev] [Openmp-dev] disabling lib/libomptarget.dylib build?

[Georgios Rokos via llvm-dev]

I have already submitted a patch here: https://reviews.llvm.org/D31055

Which does exactly what you propose. My rationale is that, since the device
plugins (CUDA, generic-elf-64) require an ELF-based system, building
libomptarget on Windows or MacOS serves no purpose at this point - even it
the library is built you cannot use it due to the lack of supported
plugins. If someone in the future develops a Windows or MacOS plugin then
we can revise this scheme.

George



From:	Jack Howarth <howarth.mailing.lists at gmail.com>
To:	Georgios Rokos/Watson/IBM at IBMUS
Cc:	"openmp-dev (openmp-dev at lists.llvm.org)"
            <openmp-dev at lists.llvm.org>, llvm-dev <llvm-dev at lists.llvm.org>
Date:	17/03/2017 14:49
Subject:	Re: [Openmp-dev] disabling lib/libomptarget.dylib build?





On Thu, Mar 16, 2017 at 1:36 PM, Georgios Rokos <grokos at us.ibm.com> wrote:
  Hi Jack,

  "Is there a cmake variable which can be set to suppress the build of
  libomptarget.dylib until this issue is fixed properly?"

  Yes, it is easy to fix. I'll submit a patch.

  George



Are you planning to retain the building of libomptarget.dylib on darwin by
avoiding the use of the unsupported -version-script linker option?
      Jack
ps Currently I am working around this issue by using the change...

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt (revision 298112)
+++ CMakeLists.txt (working copy)
@@ -4,6 +4,6 @@ set(OPENMP_LLVM_TOOLS_DIR "" CACHE PATH

 add_subdirectory(runtime)

-if (NOT WIN32)
+if (NOT WIN32 AND NOT APPLE)
   add_subdirectory(libomptarget)
 endif()


  Inactive hide details for Jack Howarth via Openmp-dev ---16/03/2017
  09:18:41---Currently trunk fails to build openmp on darwinJack Howarth
  via Openmp-dev ---16/03/2017 09:18:41---Currently trunk fails to build
  openmp on darwin due to the failure of... [ 46%] Linking CXX shared l

  From: Jack Howarth via Openmp-dev <openmp-dev at lists.llvm.org>
  To: "openmp-dev (openmp-dev at lists.llvm.org)" <openmp-dev at lists.llvm.org>,
  llvm-dev <llvm-dev at lists.llvm.org>
  Date: 16/03/2017 09:18
  Subject: [Openmp-dev] disabling lib/libomptarget.dylib build?
  Sent by: "Openmp-dev" <openmp-dev-bounces at lists.llvm.org>




  Currently trunk fails to build openmp on darwin due to the failure of...

  [ 46%] Linking CXX shared library ../../../lib/libomptarget.dylib
  cd /sw/src/fink.build/llvm50-5.0.0-1/build/stage1/projects/openmp/libomptarget

  && /sw/bin/cmake -E cmake_link_script
  CMakeFiles/omptarget.dir/link.txt --verbose=1
  /sw/src/fink.build/llvm50-5.0.0-1/opt-bin/ccclang++ -fno-common -fPIC
  -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter
  -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic
  -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor
  -Wdelete-non-virtual-dtor -Wstring-conversion -Werror=date-time
  -std=c++11 -O3 -dynamiclib -Wl,-headerpad_max_install_names  -L/sw/lib
  -o ../../../lib/libomptarget.dylib -install_name
  /sw/src/fink.build/llvm50-5.0.0-1/build/stage1/lib/libomptarget.dylib
  CMakeFiles/omptarget.dir/src/omptarget.cpp.o -ldl
  -Wl,--version-script=/sw/src/fink.build/llvm50-5.0.0-1/llvm-5.0.0.src/projects/openmp/libomptarget/exports

  ld: unknown option:
  --version-script=/sw/src/fink.build/llvm50-5.0.0-1/llvm-5.0.0.src/projects/openmp/libomptarget/exports

  clang: error: linker command failed with exit code 1 (use -v to see
  invocation)
  make[2]: *** [lib/libomptarget.dylib] Error 1
  make[1]: *** [projects/openmp/libomptarget/CMakeFiles/omptarget.dir/all]
  Error 2
  make: *** [all] Error 2

  when the cmake build attempts to use the unsupported -version-script
  linker option on darwin. Is there a cmake variable which can be set to
  suppress the build of libomptarget.dylib until this issue is fixed
  properly?
          Jack
  ps This issue is filed as http://bugs.llvm.org/show_bug.cgi?id=32309


  Bug 32309 - ld: unknown option: --version-script= failure in
  lib/libomptarget.dylib on darwin
  _______________________________________________
  Openmp-dev mailing list
  Openmp-dev at lists.llvm.org
  http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev











-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170317/80720e76/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170317/80720e76/attachment.gif>