<html><body><p><font size="2">I have already submitted a patch here: </font><a href="https://reviews.llvm.org/D31055"><font size="2">https://reviews.llvm.org/D31055</font></a><br><br><font size="2">Which does exactly what you propose. My rationale is that, since the device plugins (CUDA, generic-elf-64) require an ELF-based system, building libomptarget on Windows or MacOS serves no purpose at this point - even it the library is built you cannot use it due to the lack of supported plugins. If someone in the future develops a Windows or MacOS plugin then we can revise this scheme.</font><br><br><font size="2">George</font><br><br><img width="16" height="16" src="cid:1__=0ABB0A75DFF43DF18f9e8a93df938690918c0AB@" border="0" alt="Inactive hide details for Jack Howarth ---17/03/2017 14:49:59---On Thu, Mar 16, 2017 at 1:36 PM, Georgios Rokos <grokos@us.ibm."><font size="2" color="#424282">Jack Howarth ---17/03/2017 14:49:59---On Thu, Mar 16, 2017 at 1:36 PM, Georgios Rokos <grokos@us.ibm.com> wrote: > Hi Jack,</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Jack Howarth <howarth.mailing.lists@gmail.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Georgios Rokos/Watson/IBM@IBMUS</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">"openmp-dev (openmp-dev@lists.llvm.org)" <openmp-dev@lists.llvm.org>, llvm-dev <llvm-dev@lists.llvm.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">17/03/2017 14:49</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [Openmp-dev] disabling lib/libomptarget.dylib build?</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><br><br>On Thu, Mar 16, 2017 at 1:36 PM, Georgios Rokos <<a href="mailto:grokos@us.ibm.com" target="_blank"><u><font color="#0000FF">grokos@us.ibm.com</font></u></a>> wrote:
<ul><font size="2">Hi Jack,</font><br><font size="2"><br>"</font><tt><i><font size="2">Is there a cmake variable which can be set to suppress the build of libomptarget.dylib until this issue is fixed properly?</font></i></tt><font size="2">"</font><br><font size="2"><br>Yes, it is easy to fix. I'll submit a patch.</font><br><font size="2"><br>George</font></ul><br><br>Are you planning to retain the building of libomptarget.dylib on darwin by avoiding the use of the unsupported -version-script linker option?<br> Jack<br>ps Currently I am working around this issue by using the change...<br><br>Index: CMakeLists.txt<br>===================================================================<br>--- CMakeLists.txt (revision 298112)<br>+++ CMakeLists.txt (working copy)<br>@@ -4,6 +4,6 @@ set(OPENMP_LLVM_TOOLS_DIR "" CACHE PATH <br> <br> add_subdirectory(runtime)<br> <br>-if (NOT WIN32)<br>+if (NOT WIN32 AND NOT APPLE)<br> add_subdirectory(libomptarget)<br> endif()<br>
<ul><br><img src="cid:1__=0ABB0A75DFF43DF18f9e8a93df938690918c0AB@" width="16" height="16" alt="Inactive hide details for Jack Howarth via Openmp-dev ---16/03/2017 09:18:41---Currently trunk fails to build openmp on darwin"><font size="2" color="#424282">Jack Howarth via Openmp-dev ---16/03/2017 09:18:41---Currently trunk fails to build openmp on darwin due to the failure of... [ 46%] Linking CXX shared l</font><br><font size="2" color="#5F5F5F"><br>From: </font><font size="2">Jack Howarth via Openmp-dev <</font><a href="mailto:openmp-dev@lists.llvm.org" target="_blank"><u><font size="2" color="#0000FF">openmp-dev@lists.llvm.org</font></u></a><font size="2">></font><font size="2" color="#5F5F5F"><br>To: </font><font size="2">"openmp-dev (</font><a href="mailto:openmp-dev@lists.llvm.org" target="_blank"><u><font size="2" color="#0000FF">openmp-dev@lists.llvm.org</font></u></a><font size="2">)" <</font><a href="mailto:openmp-dev@lists.llvm.org" target="_blank"><u><font size="2" color="#0000FF">openmp-dev@lists.llvm.org</font></u></a><font size="2">>, llvm-dev <</font><a href="mailto:llvm-dev@lists.llvm.org" target="_blank"><u><font size="2" color="#0000FF">llvm-dev@lists.llvm.org</font></u></a><font size="2">></font><font size="2" color="#5F5F5F"><br>Date: </font><font size="2">16/03/2017 09:18</font><font size="2" color="#5F5F5F"><br>Subject: </font><font size="2">[Openmp-dev] disabling lib/libomptarget.dylib build?</font><font size="2" color="#5F5F5F"><br>Sent by: </font><font size="2">"Openmp-dev" <</font><a href="mailto:openmp-dev-bounces@lists.llvm.org" target="_blank"><u><font size="2" color="#0000FF">openmp-dev-bounces@lists.llvm.org</font></u></a><font size="2">></font><br><hr width="100%" size="2" align="left" noshade><br><br><br><tt><font size="2"><br>Currently trunk fails to build openmp on darwin due to the failure of...<br><br>[ 46%] Linking CXX shared library ../../../lib/libomptarget.dylib<br>cd /sw/src/fink.build/llvm50-5.0.0-1/build/stage1/projects/openmp/libomptarget<br>&& /sw/bin/cmake -E cmake_link_script<br>CMakeFiles/omptarget.dir/link.txt --verbose=1<br>/sw/src/fink.build/llvm50-5.0.0-1/opt-bin/ccclang++ -fno-common -fPIC<br>-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter<br>-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic<br>-Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor<br>-Wdelete-non-virtual-dtor -Wstring-conversion -Werror=date-time<br>-std=c++11 -O3 -dynamiclib -Wl,-headerpad_max_install_names -L/sw/lib<br>-o ../../../lib/libomptarget.dylib -install_name<br>/sw/src/fink.build/llvm50-5.0.0-1/build/stage1/lib/libomptarget.dylib<br>CMakeFiles/omptarget.dir/src/omptarget.cpp.o -ldl<br>-Wl,--version-script=/sw/src/fink.build/llvm50-5.0.0-1/llvm-5.0.0.src/projects/openmp/libomptarget/exports<br>ld: unknown option:<br>--version-script=/sw/src/fink.build/llvm50-5.0.0-1/llvm-5.0.0.src/projects/openmp/libomptarget/exports<br>clang: error: linker command failed with exit code 1 (use -v to see invocation)<br>make[2]: *** [lib/libomptarget.dylib] Error 1<br>make[1]: *** [projects/openmp/libomptarget/CMakeFiles/omptarget.dir/all] Error 2<br>make: *** [all] Error 2<br><br>when the cmake build attempts to use the unsupported -version-script<br>linker option on darwin. Is there a cmake variable which can be set to<br>suppress the build of libomptarget.dylib until this issue is fixed<br>properly?<br> Jack<br>ps This issue is filed as </font></tt><a href="http://bugs.llvm.org/show_bug.cgi?id=32309" target="_blank"><tt><u><font size="2" color="#0000FF">http://bugs.llvm.org/show_bug.cgi?id=32309</font></u></tt></a><br><tt><font size="2"><br><br>Bug 32309 - ld: unknown option: --version-script= failure in<br>lib/libomptarget.dylib on darwin</font></tt><br><tt><font size="2">_______________________________________________<br>Openmp-dev mailing list</font></tt><tt><u><font size="2" color="#0000FF"><br></font></u></tt><a href="mailto:Openmp-dev@lists.llvm.org" target="_blank"><tt><u><font size="2" color="#0000FF">Openmp-dev@lists.llvm.org</font></u></tt></a><tt><u><font size="2" color="#0000FF"><br></font></u></tt><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev" target="_blank"><tt><u><font size="2" color="#0000FF">http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev</font></u></tt></a><br><br><br></ul><br>
<p><p><BR>
</body></html>