[llvm-dev] [CommandLine] Missing clEnumValEnd for cl::values in tutorial page

Bekket McClane via llvm-dev llvm-dev at lists.llvm.org
Mon Jun 5 18:53:02 PDT 2017


Hi,

Can anyone help reviewing the code?
I think this revision is pretty important regarding that the command line library is also used in many non-LLVM projects.
It’s nice to provide a correct guideline to whom use the library for the first time.

B.R
McClane
> Bekket McClane <bekket.mcclane at gmail.com> 於 2017年6月3日 下午9:00 寫道:
> 
> Hi,
> 
> The argument list for cl::values in command line library should be end with null or clEnumValEnd. But the tutorial page(http://llvm.org/docs/CommandLine.html <http://llvm.org/docs/CommandLine.html>) doesn’t follow the rule, which would cause program crash during runtime.
> 
> I’d send a code review: https://reviews.llvm.org/D33861 <https://reviews.llvm.org/D33861>
> Please cc other folks related to this part.
> 
> Best Regards,
> Bekket McClane

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170606/806f20d7/attachment.html>


More information about the llvm-dev mailing list