<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Can anyone help reviewing the code?</div><div class="">I think this revision is pretty important regarding that the command line library is also used in many non-LLVM projects.</div><div class="">It’s nice to provide a correct guideline to whom use the library for the first time.</div><div class=""><br class=""></div><div class="">B.R</div><div class="">McClane<br class=""><div><blockquote type="cite" class=""><div class="">Bekket McClane <<a href="mailto:bekket.mcclane@gmail.com" class="">bekket.mcclane@gmail.com</a>> 於 2017年6月3日 下午9:00 寫道：</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">The argument list for cl::values in command line library should be end with null or clEnumValEnd. But the tutorial page(<a href="http://llvm.org/docs/CommandLine.html" class="">http://llvm.org/docs/CommandLine.html</a>) doesn’t follow the rule, which would cause program crash during runtime.</div><div class=""><br class=""></div><div class="">I’d send a code review: <a href="https://reviews.llvm.org/D33861" class="">https://reviews.llvm.org/D33861</a></div><div class="">Please cc other folks related to this part.</div><div class=""><br class=""></div><div class="">Best Regards,</div><div class="">Bekket McClane</div></div></div></blockquote></div><br class=""></div></body></html>