[llvm-dev] Linking Linux kernel with LLD

[George Rimar via llvm-dev]

??>On Fri, Jan 27, 2017 at 1:31 PM, Rui Ueyama <ruiu at google.com<mailto:ruiu at google.com>> wrote:

?>>Sean,
?>>
>>So as you noticed that linker script tokenization rule is not very trivial -- it is context sensitive. The current lexer is extremely >>simple and almost always works well. Improving "almost always" to "perfect" is not high priority because we have many more >>high priority things, but I'm fine if someone improves it. If you are interested, please take it. Or maybe I'll take a look at it. It >>shouldn't be hard. It's probably just a half day work.
>
>Yeah. To be clear, I wasn't saying that this was high priority. Since I'm complaining so much about it maybe I should take a look >this weekend :)?
>
?>>As far as I know, the grammar is LL(1), so it needs only one push-back buffer. Handling INCLUDE directive can be a bit tricky >>though.
?>>
>>Maybe we should rename ScriptParserBase ScriptLexer.
>
>That sounds like a good idea.
>
>-- Sean Silva

Just in case, patch implementing this ideas is D29576. Works fine.

Imho looks fine either, except part that switches lexer modes. Probably I can impove it somehow if overall
direction is ok.

George.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170208/d2cf6506/attachment.html>