<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>><span style="color: rgb(33, 33, 33); font-size: 12pt;">On Fri, Jan 27, 2017 at 1:31 PM, Rui Ueyama
</span><span dir="ltr" style="color: rgb(33, 33, 33); font-size: 12pt;"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span><span style="color: rgb(33, 33, 33); font-size: 12pt;"> wrote:</span></p>
<div style="color: rgb(33, 33, 33);">
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><span style="font-size: 12pt;">>></span><span style="font-size: 12pt;">Sean,</span><br>
<span style="font-size: 12pt;">>></span><br>
<div dir="ltr">
<div>>>So as you noticed that linker script tokenization rule is not very trivial -- it is context sensitive. The current lexer is extremely >>simple and almost always works well. Improving "almost always" to "perfect" is not high priority because we have many
more >>high priority things, but I'm fine if someone improves it. If you are interested, please take it. Or maybe I'll take a look at it. It >>shouldn't be hard. It's probably just a half day work.</div>
</div>
<div>> </div>
<div>>Yeah. To be clear, I wasn't saying that this was high priority. Since I'm complaining so much about it maybe I should take a look >this weekend :)<br>
</div>
<div>><br>
</div>
<span style="font-size: 12pt;">>></span><span style="font-size: 12pt;">A</span><span style="font-size: 12pt;">s far as I know, the grammar is LL(1), so it needs only one push-back buffer. Handling INCLUDE directive can be a bit tricky >>though.</span><br>
<span style="font-size: 12pt;">>></span><br>
<div dir="ltr">
<div>>>Maybe we should rename ScriptParserBase ScriptLexer.</div>
</div>
<div>> </div>
<div>>That sounds like a good idea.</div>
<div>> </div>
<div>>-- Sean Silva<br>
</div>
<div><br>
</div>
<div>Just in case, patch implementing this ideas is D29576. Works fine.<br>
</div>
<div><br>
</div>
<div>Imho looks fine either, except part that switches lexer modes. Probably I can impove it somehow if overall<br>
</div>
<div>direction is ok.<br>
</div>
<div><br>
</div>
<div>George.<br>
</div>
<div> <br>
</div>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>