[llvm-dev] Matthias` suggestion for "test-suite" tests that are broken at "-Ofast" and are difficult to "repair"

[Abe Skolnik via llvm-dev]

On 10/11/2016 at 4:15 PM, Matthias Braun wrote:

> I don't find it surprising that some applications do not work properly with -ffast-math and I think we
> have to accept that fact.  I think it is valid to skip those tests in the test-suite when a fast math
> flag combination is used (after making sure there is no easy way to make the test more robust).

> I would add a "TEST_SUITE_FAST_MATH" variable in the cmake build (possibly scanning CFLAGS for -ffast-math/-Ofast
>  to determine the default value) and then adding if(NOT TEST_SUITE_FAST_MATH) ... endif() 
around the benchmark.



I accept Matthias` proposal, and I propose that the above be used for wherever "really fixing" 
the FP problems with a test is beyond a reasonable effort+time level.  This email is to check 
acceptance [or lack thereof] of the above.

Regards,

Abe