[llvm-dev] Rewriting opt-viewer in C++

[Brian Cain via llvm-dev]

On Nov 17, 2016 10:36 PM, "Adam Nemet via llvm-dev" <llvm-dev at lists.llvm.org>
wrote:
>
> Hi Brian,
>
>> On Nov 17, 2016, at 3:05 PM, Brian Cain <bcain at codeaurora.org> wrote:
>>
>> Adam,
>>
>> The test case was the Python-3.6.0b3 release, 234 input YAML files.  The
large majority of time is spent with processing the file input.  Next
ranked was rendering output.  Moving the files to a tmpfs partition didn’t
change the time significantly (but I would expect that experiment would
yield different results with libYAML).
>>
>>
>> original, single-threaded:
>> processed input files 335.985792875 secs
>> mapped remarks 0.060357093811 secs
>> file rendering 70.5569140911 sec
>> index rendering 1.79133582115 sec
>>
>> x20 processes spawned:
>> processed input files 53.4612071514 secs
>> mapped remarks 0.0622367858887 secs
>> file rendering 8.30268716812 sec
>> index rendering 2.08150291443 sec
>> total time 63.9999139309 secs
>
>
> Isn’t this actually an improvement of over 6x rather than the 4x you
mentioned? ;)
>

The 4x was measured on a smaller subset of the 234 input files.

> Anyhow, do you want to properly submit a review for this?  I’d like to
try it with libYAML.
>
> In the new review, you need to add llvm-commits as a subscriber.  You may
also want to split up main into smaller functions.
>

Ok, I'll clean it up and make a real review.

> Thanks!
>
> Adam
>
>>
>>
>> -Brian
>>
>> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf
Of Adam Nemet via llvm-dev
>> Sent: Thursday, November 17, 2016 11:15 AM
>> To: Cain, Brian <bcain at quicinc.com>
>> Cc: llvm-dev <llvm-dev at lists.llvm.org>; Bob Haarman <inglorion at google.com
>
>> Subject: Re: [llvm-dev] Rewriting opt-viewer in C++
>>
>> Hi Brian,
>>
>> Great, thanks for doing this!
>>
>> Can you please share the timing printouts?  Are we spending most of the
time in parsing?
>>
>> Is this on an internal test case?
>>
>> Adam
>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161117/fd72259b/attachment-0001.html>