[llvm-dev] Phabricator/Arcanist feedback
Joerg Sonnenberger via llvm-dev
llvm-dev at lists.llvm.org
Fri Jan 8 07:39:09 PST 2016
On Fri, Jan 08, 2016 at 09:29:01AM -0600, Krzysztof Parzyszek via llvm-dev wrote:
> On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote:
> >
> >One thing that bit me a few times is the fact that the Differential
> >Revision: line must be the last (non-empty) line in the commit message.
> >If you add things like “This fixes …” behind it then it won’t get
> >recognized.
>
> My biggest grievance with Phabricator is that you can't just close a
> revision manually. It seems that unless you use arcanist, you need to
> resort to some sort of trickery to get your revisions closed.
Huh? Under "Leap into action" on the bottom of the page, there is "Close
revision".
Joerg
More information about the llvm-dev
mailing list