[llvm-dev] Phabricator/Arcanist feedback

Krzysztof Parzyszek via llvm-dev llvm-dev at lists.llvm.org
Fri Jan 8 07:29:01 PST 2016


On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote:
>
> One thing that bit me a few times is the fact that the Differential
> Revision: line must be the last (non-empty) line in the commit message.
> If you add things like “This fixes …” behind it then it won’t get
> recognized.

My biggest grievance with Phabricator is that you can't just close a 
revision manually.  It seems that unless you use arcanist, you need to 
resort to some sort of trickery to get your revisions closed.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-dev mailing list