[llvm-dev] [FileCheck] Fix --strict-whitespace --match-full-lines

[Robinson, Paul via llvm-dev]

> -----Original Message-----
> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of
> Jonathan Roelofs via llvm-dev
> Sent: Wednesday, December 14, 2016 8:32 AM
> To: Tom de Vries; llvm-dev at lists.llvm.org
> Subject: Re: [llvm-dev] [FileCheck] Fix --strict-whitespace --match-full-
> lines
> 
> +jyknight, who added --match-full-lines
> 
> 
> On 12/14/16 5:37 AM, Tom de Vries wrote:
> > Hi,
> >
> > this patch fixes a problem with leading/trailing whitespace matching
> > for FileCheck --strict-whitespace --match-full-lines.
> >
> > The resulting regexp string is '^bla3$' instead of '^ bla3$'.
> >
> > The patch fixes this, and makes the behavior match the documentation.
> >
> > I ran the llvm/test/FileCheck tests, no regressions.
> 
> Should probably run the entire llvm testsuite, if not clang's too. I
> doubt FileCheck's own tests have good coverage of the tool itself.

They are smoke tests, like most of clang/llvm lit tests.
Running the full clang/llvm lit suites with the modified FileCheck
seems like a pretty reasonable exercise.
--paulr

> 
> 
> Jon
> 
> >
> > Any comments? OK for trunk?
> >
> > Thanks,
> > - Tom
> 
> --
> Jon Roelofs
> jonathan at codesourcery.com
> CodeSourcery / Mentor Embedded
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev