[llvm-dev] [FileCheck] Fix --strict-whitespace --match-full-lines

Jonathan Roelofs via llvm-dev llvm-dev at lists.llvm.org
Wed Dec 14 08:32:03 PST 2016


+jyknight, who added --match-full-lines


On 12/14/16 5:37 AM, Tom de Vries wrote:
> Hi,
>
> this patch fixes a problem with leading/trailing whitespace matching 
> for FileCheck --strict-whitespace --match-full-lines.
>
> The resulting regexp string is '^bla3$' instead of '^ bla3$'.
>
> The patch fixes this, and makes the behavior match the documentation.
>
> I ran the llvm/test/FileCheck tests, no regressions.

Should probably run the entire llvm testsuite, if not clang's too. I 
doubt FileCheck's own tests have good coverage of the tool itself.


Jon

>
> Any comments? OK for trunk?
>
> Thanks,
> - Tom

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the llvm-dev mailing list