[llvm-dev] Move InlineCost.cpp out of Analysis?

Hal Finkel via llvm-dev llvm-dev at lists.llvm.org
Mon Apr 18 14:07:36 PDT 2016

----- Original Message -----
> From: "Easwaran Raman" <eraman at google.com>
> To: "via llvm-dev" <llvm-dev at lists.llvm.org>
> Cc: "Chandler Carruth" <chandlerc at gmail.com>, "Hal Finkel" <hfinkel at anl.gov>, "Philip Reames"
> <listmail at philipreames.com>, "David Li" <davidxl at google.com>
> Sent: Monday, April 18, 2016 2:39:49 PM
> Subject: Move InlineCost.cpp out of Analysis?
> Hi,
> After r256521 - which removes InlineCostAnalysis class - I think
> there is no strong reason for InlineCost.cpp to be part of the
> Analysis library. Is it fine to make it part of TransformUtils?

Given that InlineCost is not really an analysis any longer, I think this is fine.


> I submitted r266477 (which has now been reverted) that made Analysis
> depend on ProfileData in order to obtain ProfileSummary for the
> module, but there is an existing dependency of ProfileData on
> Analysis (through Object and BitCode). Moving InlineCost.cpp under
> Transforms/Utils will fix this issue. There are other ways to fix
> this (make Inliner.cpp get the ProfileSummary and pass it to
> InlineCost, for example), but I think it makes sense to move
> InlineCost.
> Thoughts?
> Thanks,
> Easwaran

Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory

More information about the llvm-dev mailing list