[llvm-dev] Move InlineCost.cpp out of Analysis?

Easwaran Raman via llvm-dev llvm-dev at lists.llvm.org
Mon Apr 18 12:39:49 PDT 2016


  After r256521 - which removes InlineCostAnalysis class -  I think there
is no strong reason for InlineCost.cpp to be part of the Analysis library.
Is it fine to make it part of TransformUtils?

I submitted r266477 (which has now been reverted) that made Analysis depend
on ProfileData in order to obtain ProfileSummary for the module, but there
is an existing dependency of ProfileData on Analysis (through Object and
BitCode). Moving InlineCost.cpp under Transforms/Utils will fix this issue.
There are other ways to fix this (make Inliner.cpp get the ProfileSummary
and pass it to InlineCost, for example), but I think it makes sense to
move InlineCost.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160418/d8090250/attachment.html>

More information about the llvm-dev mailing list