[LLVMdev] [cfe-dev] Commit message policy?

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Mar 6 16:07:07 PST 2015


> -----Original Message-----
> From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] On
> Behalf Of Renato Golin
> Sent: Friday, March 06, 2015 1:13 PM
> To: Reid Kleckner
> Cc: Clang Dev; LLVM Dev
> Subject: Re: [cfe-dev] [LLVMdev] Commit message policy?
> 
> On 6 March 2015 at 20:59, Reid Kleckner <rnk at google.com> wrote:
> > I think the only guideline we should have is that the first line should
> be
> > written as though it is an email subject, because it gets used for that.
> If
> > you write a long first line, then you get a long subject, and it looks
> > silly. If people want to embarrass themselves with strangely formatted
> > email, they it's on them. We don't need a specific hard or soft number.
> 
> Not many people care about the email subject already, that's why they
> keep using ridiculously long first lines.
> 
> IMO, "suggesting" to write short first lines is the same as not doing
> anything. Either we add a cap (say, 80 chars), or we don't do
> anything.
> 
> Chandler's other suggestion, tough, is interesting: to write up a bit
> about what a *good* message would be, so the people that were really
> interested, could do it "right" (tm).

Renato,
Let me reflect this back to you, to make sure I understood it:

You don't like the idea of "suggesting" how to write a good message,
but you're okay with describing what a good message looks like? (as long
as we don't suggest that people should actually write them that way.)
--paulr

> 
> cheers,
> --renato
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev




More information about the llvm-dev mailing list