[LLVMdev] [cfe-dev] Phabricator update
Manuel Klimek
klimek at google.com
Wed Jul 8 03:31:33 PDT 2015
Those seem to be comments by the original author? Is this a problem?
On Wed, Jul 8, 2015 at 10:31 AM Tamas Berghammer <tberghammer at google.com>
wrote:
> Hi Manual,
>
> Since the Phabricator update I noticed that the username of the reviewer
> isn't displayed for some comment added to the review (e.g.:
> http://reviews.llvm.org/D11016). Can you check it out what is causing
> this issue?
>
> Thanks,
> Tamas
>
>
> On Fri, Jul 3, 2015 at 9:50 AM Manuel Klimek <klimek at google.com> wrote:
>
>> On Fri, Jul 3, 2015 at 10:02 AM Andrew Wilkins <axwalk at gmail.com> wrote:
>>
>>> On Fri, 3 Jul 2015 at 01:43 Manuel Klimek <klimek at google.com> wrote:
>>>
>>>> On Thu, Jul 2, 2015 at 7:27 PM Jonathan Roelofs <
>>>> jonathan at codesourcery.com> wrote:
>>>>
>>>>> Even further off topic, in phab wishlist land: It'd be awesome if it
>>>>> were capable of inferring extended patch context by looking at the svn
>>>>> repo/git mirrors (rather than requiring the person submitting the patch
>>>>> to re-upload with -U999).
>>>>>
>>>>
>>>> Yea, this is hard, because detecting which path a patch goes against is
>>>> hard (for example, if the patch path is a pure add for a new tools/sometool
>>>> directory, is it in clang or llvm?) and requiring people to do global
>>>> top-level llvm patches seems rather problematic.
>>>>
>>>> The workaround is to use arc diff (the command line tool).
>>>>
>>>
>>> Speaking of which, in case anyone else has issues with arc today, this
>>> might save you a minute or two.
>>>
>>> $ arc diff
>>> Exception
>>> ERR-CONDUIT-CALL: API Method "differential.query" does not define these
>>> parameters: 'arcanistProjects'.
>>> (Run with --trace for a full exception trace.)
>>>
>>> Fix this by upgrading with "arc upgrade".
>>>
>>> Then, say you're sending a patch for Clang, you'll need to use
>>> "cfe-commits-list" in the subscriber list instead of "cfe-commits".
>>> Otherwise you get:
>>>
>>> """
>>> Commit message has errors:
>>> - Error parsing field "Subscribers": The objects you have listed
>>> include objects which do not exist (cfe-commits).
>>> """
>>>
>>> (this might be temporary?)
>>>
>>
>> Thanks for reporting - this happened as part of the upgrade automatically
>> (mailing lists were migrated to mailing list users). Changed the names
>> back, you should be able to type cfe-commits/llvm-commits/lldb-commits
>> again.
>>
>>
>>>
>>> Cheers,
>>> Andrew
>>>
>>>
>>>>
>>>>>
>>>>>
>>>>> Jon
>>>>>
>>>>> On 7/2/15 10:52 AM, Keno Fischer wrote:
>>>>> > This might be slightly off topic, but I'd really like a way to be
>>>>> able
>>>>> > to run the buildbots off a Phabricator Diff before committing.
>>>>> >
>>>>> > On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <klimek at google.com
>>>>> > <mailto:klimek at google.com>> wrote:
>>>>> >
>>>>> > Unfortunately threading will be broken for changes currently
>>>>> under
>>>>> > review (new patches shouldn't have the problem).
>>>>> > I'm very sorry for this inconvenience :(
>>>>> >
>>>>> > On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <klimek at google.com
>>>>> > <mailto:klimek at google.com>> wrote:
>>>>> >
>>>>> > Greetings llvm'ers,
>>>>> >
>>>>> > I'm working on an update to phabricator that brings our fork
>>>>> > significantly closer to the upstream version, thus making
>>>>> > maintenance much easier; this will allow us to upgrade more
>>>>> often.
>>>>> >
>>>>> > Upstream has fixed many issues and introduced new ways to
>>>>> > customize the email flow, so
>>>>> >
>>>>> > a) while rolling out the new version I'll be fiddling with
>>>>> > config settings; during that time, you might see emails that
>>>>> are
>>>>> > not yet what we'll want the end-state to be; I'll announce on
>>>>> > this thread once this is done
>>>>> >
>>>>> > b) the new version gives people more control over the emails;
>>>>> > that means, if you're a phab user, you might get some emails
>>>>> > that the list doesn't get (if you wish to); you can configure
>>>>> > that from phab's email settings
>>>>> >
>>>>> > Once this is finished, please respond on this thread with
>>>>> your
>>>>> > concerns / comments, or file bugs at
>>>>> > https://llvm.org/bugs/enter_bug.cgi?product=Website
>>>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=W103a0YcLyjwDrTAWoFBe3Uu-dnd8C25faPQ_R6tCes&s=l2z19ixng4bNngaOKUrrMcJuK_MKRswvSTSHI6Oz3do&e=>
>>>>> > <
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=
>>>>> >.
>>>>> >
>>>>> > Cheers,
>>>>> > /Manuel
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > LLVM Developers mailing list
>>>>> > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu>
>>>>> http://llvm.cs.uiuc.edu
>>>>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > cfe-dev mailing list
>>>>> > cfe-dev at cs.uiuc.edu
>>>>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>>>>> >
>>>>>
>>>>> --
>>>>> Jon Roelofs
>>>>> jonathan at codesourcery.com
>>>>> CodeSourcery / Mentor Embedded
>>>>>
>>>> _______________________________________________
>>>> LLVM Developers mailing list
>>>>
>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>>>
>>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150708/a25c27e7/attachment.html>
More information about the llvm-dev
mailing list