[LLVMdev] LLD: make atoms in files non-const

Rui Ueyama ruiu at google.com
Wed Apr 8 14:38:22 PDT 2015


Looks like there's no push-back, so I'll start working on this. Before
that, it looks like I have to simplify atom_collection and its iterators,
so I'll start off with that. Thanks!

On Wed, Apr 8, 2015 at 10:59 AM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

> On 4/7/2015 5:58 PM, Rui Ueyama wrote:
>
>> Currently, member functions like File::defined() return an iterator for
>> const atoms. But we don't actually treat atoms as consts -- we updates
>> atoms in many places including the core resolver.
>>
>> We have too many const_casts in our code. It just doesn't make sense.
>>
>> I'm making a change to make atoms non-const. Please hit reply if you have
>> any concerns.
>>
>>  Returning a non const iterator would be a nice change.
>
> Shankar Easwaran
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150408/93e7b1c7/attachment.html>


More information about the llvm-dev mailing list