[LLVMdev] [llvm][SelectionDAG] trivial patch: fix misprint in SelectionDAGLegalize::ExpandInsertToVectorThroughStack

Owen Anderson resistor at mac.com
Mon Nov 17 10:16:27 PST 2014


Alright, go ahead with it.

—Owen

> On Nov 17, 2014, at 4:58 AM, Daniil Troshkov <troshkovdanil at gmail.com> wrote:
> 
> Hi!
>  
> I have not found test case. (It is because we have no target using "ExpandInsertToVectorThroughStack").
> But I tested it for target currently not included in llvm trunk.
>  
> This fix correct and trivial, so I'm offering to commit it...
> 
> On Wed, Nov 12, 2014 at 11:47 PM, Daniil Troshkov <troshkovdanil at gmail.com <mailto:troshkovdanil at gmail.com>> wrote:
> I detected this bug using test case from platform which is not currently supported on llvm targets. (Our team is porting llvm on new target).
> Creating the test case will take some extra time. I'll try to do it ASAP.
> Have you any ideas about the test case? (targets using ExpandInsertToVectorThroughStack, etc...)
> 
> 
> On Wed, Nov 12, 2014 at 8:29 PM, Owen Anderson <resistor at mac.com <mailto:resistor at mac.com>> wrote:
> LGTM.  Can you supply a testcase?
> 
> —Owen
> 
> > On Nov 12, 2014, at 5:52 AM, Daniil Troshkov <troshkovdanil at gmail.com <mailto:troshkovdanil at gmail.com>> wrote:
> >
> > Hi Owen!
> >
> > The "First store the whole vector" is without uses and will be deleted later.
> > I've attached trivial patch to fix it.
> > I have no commit access so if patch is OK, please, commit it .
> >
> > Danil.
> > <ExpandInsertToVectorThroughStack.patch>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141117/08b773dc/attachment.html>


More information about the llvm-dev mailing list