<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Alright, go ahead with it.<div class=""><br class=""></div><div class="">—Owen</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 17, 2014, at 4:58 AM, Daniil Troshkov <<a href="mailto:troshkovdanil@gmail.com" class="">troshkovdanil@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Hi!</div><div class=""> </div><div class="">I have not found test case. (It is because we have no target using "ExpandInsertToVectorThroughStack").</div><div class="">But I tested it for target currently not included in llvm trunk.</div><div class=""> </div><div class="">This fix correct and trivial, so I'm offering to commit it...</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Nov 12, 2014 at 11:47 PM, Daniil Troshkov <span dir="ltr" class=""><<a href="mailto:troshkovdanil@gmail.com" target="_blank" class="">troshkovdanil@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I detected this bug using test case from platform which is not currently supported on llvm targets. (Our team is porting llvm on new target).<br class="">Creating the test case will take some extra time. I'll try to do it ASAP.<br class="">Have you any ideas about the test case? (targets using ExpandInsertToVectorThroughStack, etc...)<br class=""><br class=""></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Nov 12, 2014 at 8:29 PM, Owen Anderson <span dir="ltr" class=""><<a href="mailto:resistor@mac.com" target="_blank" class="">resistor@mac.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">LGTM. Can you supply a testcase?<br class="">
<br class="">
—Owen<br class="">
<div class=""><div class=""><br class="">
> On Nov 12, 2014, at 5:52 AM, Daniil Troshkov <<a href="mailto:troshkovdanil@gmail.com" target="_blank" class="">troshkovdanil@gmail.com</a>> wrote:<br class="">
><br class="">
> Hi Owen!<br class="">
><br class="">
> The "First store the whole vector" is without uses and will be deleted later.<br class="">
> I've attached trivial patch to fix it.<br class="">
> I have no commit access so if patch is OK, please, commit it .<br class="">
><br class="">
> Danil.<br class="">
</div></div>> <ExpandInsertToVectorThroughStack.patch><br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>