[LLVMdev] Changing the design of GlobalAliases to represent what is actually possible in object files.

John McCall rjmccall at apple.com
Tue May 27 08:53:41 PDT 2014


On May 26, 2014, at 3:25 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>> Judging from what I have seen so far I would be OK with
>> 
>> * Supporting only symbol + offset and representing that directly.
>> * Supporting "any" ConstantExpr.
> 
> Most of the uses of getAliasee were (or are) bugs and missing
> features. With those out of the way, the tradeoff of the above options
> becomes having the ability to represent any symbol value that the
> assembler can at the cost of far weaker checking for the expressions
> defining the global alias.
> 
> I reported the most annoying IR X object file mismatch as pr19848.
> Since it is present in both representation we can handle it after
> this.
> 
> The attached patches are on top of the patch I emailed for pr19844.
> 
> Is everyone sufficiently satisfied with this direction? Can I resend
> the patches to llvm-commits  and cfe-commits?

This direction looks great to me.  Thank you, Rafael!

Not a full review, but typo:

+Since aliasess are only

John.



More information about the llvm-dev mailing list