[LLVMdev] Virtual Studio hack in APFloat.h

Aaron Ballman aaron at aaronballman.com
Tue Mar 18 11:32:28 PDT 2014


On Tue, Mar 18, 2014 at 2:15 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> Hi all
>
> APFloat.h contains this code, which was required for Visual Studio builds.
>
> Given that this was committed in r41784 (2007), does anyone know if newer
> versions work?  I think after moving to C++11 we’re on VS2013 at a minimum?
> I’d have hoped it would be more likely to work.

We use VS 2012 as a minimum, which I don't happen to have handy. But I
tried modifying APFloat.h to use 2 instead of 3 bits, and still get
failures.

Are we allowed to use enum classes? Perhaps that would be sufficient
to convince MSVC to leave it unsigned.

~Aaron




More information about the llvm-dev mailing list