[LLVMdev] Another phabricator feature request...

[Manuel Klimek]

On Mon, Jun 30, 2014 at 11:01 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 30 June 2014 09:52, Manuel Klimek <klimek at google.com> wrote:
> > I'm not sure why those are related - you can simply self-accept a
> revision
> > (which probably shouldn't send an LG). This is because many people don't
> use
> > phab, and so the LG only comes via the mailing list.
>
> I think if we're going to have any control flow in phab, we should
> have it minimally functional. That was just an example of it being
> non-functional (ie. performing an extra useless step in order to
> complete another).
>
> So, either we keep the flow control as text (list or phab, doesn't
> matter), and stop any checking of state change in phab, or we let phab
> help, and make it either send an email of acceptance or add LGTM
> whenever the user choose "Accept" in the drop down.
>
> Having a non-functional flow control that burdens the users is another
> reason for people not to use it.
>

I agree that the workflow is not optimal yet, and I'm going to work on
making it better.


>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140630/6bfa8e32/attachment.html>