[LLVMdev] Another phabricator feature request...

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Jun 27 13:52:04 PDT 2014


> On 2014-Jun-27, at 11:50, Michael Spencer <bigcheesegs at gmail.com> wrote:
> 
> On Fri, Jun 27, 2014 at 11:39 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
>> I know you worked hard to make sure that updating a revision doesn't send
>> email unless there is text typed into one of the boxes Manuel, but I think
>> we should by default put some text into a box (and send the email unless the
>> user deletes that text) when accepting a revision. Otherwise, the final LGTM
>> can accidentally happen on Phab and not reach the mailing list (D4178 for
>> example).
>> 
>> Thoughts?
>> 
> 
> Is there any reason not to have accepts always send an email?
> 
> - Michael Spencer

If it's possible to make "accept" send an email with the text "LGTM",
that would design away another source of discontinuity between the
list and Phab.



More information about the llvm-dev mailing list