[LLVMdev] Another phabricator feature request...

Michael Spencer bigcheesegs at gmail.com
Fri Jun 27 11:50:32 PDT 2014


On Fri, Jun 27, 2014 at 11:39 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> I know you worked hard to make sure that updating a revision doesn't send
> email unless there is text typed into one of the boxes Manuel, but I think
> we should by default put some text into a box (and send the email unless the
> user deletes that text) when accepting a revision. Otherwise, the final LGTM
> can accidentally happen on Phab and not reach the mailing list (D4178 for
> example).
>
> Thoughts?
>

Is there any reason not to have accepts always send an email?

- Michael Spencer



More information about the llvm-dev mailing list