[LLVMdev] Phabricator and private reviews

[Manuel Klimek]

On Thu, Jun 26, 2014 at 12:32 PM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

>     > > Manuel: I'm aware of one other way for a review to be invisible
> to llvm-commits despite being
> > > CC'd. If you forget to CC llvm-commits when creating the differential
> revision and add it later in
> > > the web interface, Phabricator doesn't send an email to the list.
> Adding a comment (at the same
> > > time or afterwards) triggers an email.
> > > The same thing happens when adding reviewers without a comment.
> >
> > That is intentional. We don't want to spam the list with changes in phab
> - use phab like you would use email, and everything should be fine.
>
> Hmm. If I reply-all to an email, add a new recipient but forget to write
> anything, everyone still receives the email. Admittedly not writing
> anything would be unusual.
>
>
>
> Well, if you don't hit "send" nothing gets sent :)
>
>
>
> Ack! Well spotted. You've also reminded me that I hadn't asked the
> Phabricator developers if it was possible to contribute without a Facebook
> account. I wrote the email but hadn't sent it. I was going to send them a
> patch adding a way to edit the commit message using 'arc commit'.
>

Yes, it's no problem - they'll happily send you a different developer
agreement that's targetted towards their current company if you ask...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140626/5e3a4794/attachment.html>