[LLVMdev] Usability of phabricator review threads for non-phab-users

[Manuel Klimek]

On Sun, Jul 6, 2014 at 4:42 AM, Nick Lewycky <nicholas at mxc.ca> wrote:

> Chandler Carruth wrote:
>
>>
>> On Thu, Jul 3, 2014 at 11:00 PM, Nick Lewycky <nicholas at mxc.ca
>> <mailto:nicholas at mxc.ca>> wrote:
>>
>>     I don't like the lack attached patch files on the mailing list to do
>>     a normal review.
>>
>>
>> Wait what? The emails I get from phab *have* an attached patch file.
>> That was a hard requirement when we first set up Phabricator.
>>
>
> Aaron nailed it. The initial emails come with attached patches. The
> problem is when people comment with the changes they made to the code, but
> there's no updated patch attached to that email. Aaron found examples so
> I'll defer to those. I can also keep an eye out for the next time it
> happens if you want.


You should usually see 2 messages directly after each other - one with the
patch, and one with the comment updates.


>
>
> Nick
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140706/5d3f0748/attachment.html>