[LLVMdev] Why doesn't GlobalVariable::copyAttributesFrom copy the thread local mode?

Hans Wennborg hans at chromium.org
Mon Feb 10 09:20:42 PST 2014


On Mon, Feb 10, 2014 at 8:17 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 8 February 2014 00:40, Keno Fischer <kfischer at college.harvard.edu> wrote:
>> GlobalVariable::copyAttributesFrom sets the target thread local mode to
>> either general dynamic or not thread local rather than copying the thread
>> local mode from the source. Is that intentional or an oversight?
>
> I think it is just not implemented yet. We added support for having
> explicit thread mode in r159077 and I think we just forgot to update
> this code.

Fixed in r201098.

Thanks,
Hans




More information about the llvm-dev mailing list