[LLVMdev] 3.5.1 Testing Phase II Begins

Chandler Carruth chandlerc at google.com
Mon Dec 29 12:04:09 PST 2014


On Mon, Dec 29, 2014 at 11:52 AM, David Majnemer <david.majnemer at gmail.com>
wrote:

> The most relevant of these is r222856 which reverted a set of broken
> optimizations in r210006.  I'd be happy with just including r222856.


FWIW, I've reviewed this and it is a very safe patch. I would approve it
even at this late stage because (for example) they have exactly zero impact
on different platforms, and so should require minimal testing. I think the
only question is whether this creates an unreasonable disruption of the
3.5.1 release, and that's really a question for Tom.

  Optionally, we could take r222868 and r222871 which correctly restore the
> optimization.


These I don't think are reasonable at this stage IMO.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141229/00ccb125/attachment.html>


More information about the llvm-dev mailing list