[LLVMdev] [PATCH] Seh exceptions on Win64

[Yaron Keren]

Hi Chandler,

This is what Ray wrote on Phabricator  http://reviews.llvm.org/D3422 :

  mingwandroid <http://reviews.llvm.org/p/mingwandroid/> commented on this
revision.

  Hi. I am the original author of this patch and am happy for our to be
submitted for inclusion via this submission.

  Best regards,

  Ray Donnelly.


Is this acceptable or do we need anything else?


Yaron




2014-04-18 23:08 GMT+03:00 Chandler Carruth <chandlerc at google.com>:

> On Fri, Apr 18, 2014 at 5:29 AM, Yaron Keren <yaron.keren at gmail.com>wrote:
>
>> In summary we have no less than six patches required to support Win64 SEH
>> MinGW. The first five could be committed after review and LGTM but the last
>> one also requires Ray Donnelly approval.
>>
>
> No, it really requires that Ray Donnelly *contribute* the patch. That is
> different.
>
>
> Also, folks informed us of at least one place where a patch posted to the
> list by Kai in the past from the LDC / redstar.de work contained copied
> copyrighted material that Kai did not hold the rights to, and was not
> available under *any* license. This is really concerning, and it means that
> any significant contributions from this body of work need to be very
> carefully audited for other places where this has happened. I'm not sure of
> any good way to do that at this point.
>
> This isn't to say we don't want to support the win64 ABI and exception
> handling stuff, we really do (and thanks for working on it!), but we need
> to be careful about how we do it.
>
> My suggestion if you want to move this forward quickly would be for folks
> who are interested author their own patches independently, without any
> reference to or basis on existing work, and contribute that patch. That is
> what folks here are planning to do for their ABI work.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/62984e62/attachment.html>