<div dir="rtl"><div dir="ltr">Hi Chandler,</div><div dir="ltr"><br></div><div dir="ltr">This is what Ray wrote on Phabricator <a href="http://reviews.llvm.org/D3422">http://reviews.llvm.org/D3422</a> :</div><div dir="ltr">
<br></div><div dir="ltr"><div class="" style="margin:0px;padding:5px 8px;border:0px;background-color:rgb(247,247,247);color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;line-height:16.003000259399414px">
<div style="margin:0px;padding:0px;border:0px"> <a href="http://reviews.llvm.org/p/mingwandroid/" class="" style="text-decoration:none;color:rgb(24,85,157);font-weight:bold">mingwandroid</a> commented on this revision.</div>
</div><div class="" style="margin:0px;padding:8px;border:0px;overflow:auto;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;line-height:16.003000259399414px"><div class="" style="margin:0px;padding:0px;border:0px">
<div class="" style="margin:0px;padding:0px;border:0px;line-height:1.45em"><p style="margin:0px 0px 1em;padding:0px;border:0px"> Hi. I am the original author of this patch and am happy for our to be submitted for inclusion via this submission.</p>
<p style="margin:0px 0px 1em;padding:0px;border:0px"> Best regards,</p><p style="margin:0px;padding:0px;border:0px"> Ray Donnelly.</p><p style="margin:0px;padding:0px;border:0px"><br></p><p style="margin:0px;padding:0px;border:0px">
Is this acceptable or do we need anything else?</p><p style="margin:0px;padding:0px;border:0px"><br></p><p style="margin:0px;padding:0px;border:0px">Yaron</p><p style="margin:0px;padding:0px;border:0px"><br></p></div></div>
</div></div></div><div class="gmail_extra"><div dir="ltr"><br><br><div class="gmail_quote">2014-04-18 23:08 GMT+03:00 Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 .8ex;border-left:1px #ccc solid;border-right:1px #ccc solid;padding-left:1ex;padding-right:1ex"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Fri, Apr 18, 2014 at 5:29 AM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">In summary we have no less than six patches required to support Win64 SEH MinGW. The first five could be committed after review and LGTM but the last one also requires <span style="font-size:12.727272033691406px;font-family:arial,sans-serif">Ray </span><span style="line-height:18.850000381469727px;font-size:13px;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif">Donnelly</span><span style="line-height:18.850000381469727px;font-size:13px;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif"> approval.</span></div>
</div></blockquote><div><br></div></div><div>No, it really requires that Ray Donnelly *contribute* the patch. That is different.</div><div><br></div><div><br></div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">
Also, folks informed us of at least one place where a patch posted to the list by Kai in the past from the LDC / <a href="http://redstar.de/" target="_blank">redstar.de</a> work contained copied copyrighted material that Kai did not hold the rights to, and was not available under *any* license. This is really concerning, and it means that any significant contributions from this body of work need to be very carefully audited for other places where this has happened. I'm not sure of any good way to do that at this point.</div>
<div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px"><br></div><div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px">This isn't to say we don't want to support the win64 ABI and exception handling stuff, we really do (and thanks for working on it!), but we need to be careful about how we do it.</div>
<div class="gmail_extra" style="font-family:arial,sans-serif;font-size:13px"><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">My suggestion if you want to move this forward quickly would be for folks who are interested author their own patches independently, without any reference to or basis on existing work, and contribute that patch. That is what folks here are planning to do for their ABI work.</span></div>
</div></div></blockquote></div></div></div>