[LLVMdev] [PATCH] Seh exceptions on Win64
Martell Malone
martellmalone at gmail.com
Fri Apr 18 04:42:48 PDT 2014
Hi chandler,
Sorry for the confusion.
I've never submitted patches before.
I'll cc Ray to get him to confirm that the patch can be merged. His header
should be on the patch also so that's how you know it is his.
Yes Yaron the names above seem and the detail seem correct to me except
that the MinGW driver derived from Rubens submission to LLVM reviews some
months ago.
I said that at the start of the thread.
Basically the guys including Ray were looking to have an x64 mingw64
working with clang. So I fixed Rubens patch and kai's patch for head
I'm not concerned with having my name on any attribution I just want them
all merged as this combination of patches fixes mingw64 x64 with clang.
Kind Regards
Martell
On 18 Apr 2014 11:11, "Yaron Keren" <yaron.keren at gmail.com> wrote:
> Hi Chandler,
>
> There were five SEH releated patches posted in two threads in the last
> days.
>
> Two different patches in Martell e-mail starting this thread: the win64
> seh (llvm) and the register names
>
> Three more related SEH patches in another thread: one for win64 seh clang,
> one for MinGW toolchain and another for unreachable prologue.
>
> To clarify and allow proper reviews for the different patches I opened
> reviews for four of them (the fifth got LGTM in the discussion but it does
> have the ownership issue you wrote)
>
> D3417
> Emit a trap instruction for IR 'unreachable<http://reviews.llvm.org/D3417>
>
> D3418
> SEH exceptions on Win64 (LLVM) <http://reviews.llvm.org/D3418>
>
> D3419
> SEH exceptions on Win64 (clang part) <http://reviews.llvm.org/D3419>
>
> D3420
> MinGW toolchain <http://reviews.llvm.org/D3420>
>
>
> Per your suggestion the link to the original discussion in D3418 was added.
>
> Code authors are:
> unreachable is by Vadim Chugunov.
> win64 seh llvm is by Kai Nacke + Martell re-posting.
> win64 seh clang is by Martell.
> mingw toolchain is by Martell.
> register names is by Ray Donnelly + Martell posting it.
> seh test for "register names" ( test is r206566) by myself.
>
> All but the "register names" patch were posted by their author on the
> llvm lists.
>
> Yaron
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/e9984133/attachment.html>
More information about the llvm-dev
mailing list