<p dir="ltr">Hi chandler,</p>
<p dir="ltr">Sorry for the confusion.<br>
I've never submitted patches before.<br>
I'll cc Ray to get him to confirm that the patch can be merged. His header should be on the patch also so that's how you know it is his.</p>
<p dir="ltr">Yes Yaron the names above seem and the detail seem correct to me except that the MinGW driver derived from Rubens submission to LLVM reviews some months ago.<br>
I said that at the start of the thread.</p>
<p dir="ltr">Basically the guys including Ray were looking to have an x64 mingw64 working with clang. So I fixed Rubens patch and kai's patch for head</p>
<p dir="ltr">I'm not concerned with having my name on any attribution I just want them all merged as this combination of patches fixes mingw64 x64 with clang.</p>
<p dir="ltr">Kind Regards<br>
Martell</p>
<div class="gmail_quote">On 18 Apr 2014 11:11, "Yaron Keren" <<a href="mailto:yaron.keren@gmail.com">yaron.keren@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="rtl"><div dir="ltr">Hi Chandler,</div><div dir="ltr"><br></div><div dir="ltr">There were five SEH releated patches posted in two threads in the last days.</div><div dir="ltr"><br></div><div dir="ltr">Two different patches in Martell e-mail starting this thread: the win64 seh (llvm) and the register names</div>
<div dir="ltr"><br></div><div dir="ltr">Three more related SEH patches in another thread: one for win64 seh clang, one for MinGW toolchain and another for unreachable prologue. </div><div dir="ltr"><br></div><div dir="ltr">
To clarify and allow proper reviews for the different patches I opened reviews for four of them (the fifth got LGTM in the discussion but it does have the ownership issue you wrote)<br></div><div dir="ltr"><br></div><div dir="ltr">
<span style="font-size:13px;color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3417</span><span style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold"> </span><div style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;display:inline-block;margin:0px;font-weight:bold;border:0px;padding:0px">
<a href="http://reviews.llvm.org/D3417" style="color:rgb(24,85,157);text-decoration:none" target="_blank">Emit a trap instruction for IR 'unreachable</a></div><br></div><div dir="ltr"><span style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3418</span><span style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold"> </span><div style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;display:inline-block;margin:0px;font-weight:bold;border:0px;padding:0px">
<a href="http://reviews.llvm.org/D3418" style="text-decoration:none;color:rgb(24,85,157)" target="_blank">SEH exceptions on Win64 (LLVM)</a></div><br></div><div dir="ltr"><span style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3419</span><span style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold"> </span><div style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;display:inline-block;margin:0px;font-weight:bold;border:0px;padding:0px">
<a href="http://reviews.llvm.org/D3419" style="text-decoration:none;color:rgb(24,85,157)" target="_blank">SEH exceptions on Win64 (clang part)</a></div><br></div><div dir="ltr"><span style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3420</span><span style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold"> </span><div style="line-height:16.003000259399414px;font-size:13px;background-color:rgb(240,240,240);white-space:nowrap;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;display:inline-block;margin:0px;font-weight:bold;border:0px;padding:0px">
<a href="http://reviews.llvm.org/D3420" style="text-decoration:none;color:rgb(24,85,157)" target="_blank">MinGW toolchain</a></div><br></div><div dir="ltr"><br></div><div dir="ltr"><div>Per your suggestion the link to the original discussion in D3418 was added.</div>
<div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Code authors are:</font></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">unreachable is by Vadim </span><span style="line-height:18.850000381469727px;font-size:13px;font-family:'Helvetica Neue',Helvetica,Arial,sans-serif">Chugunov.</span></div>
<div dir="ltr">win64 seh llvm is by Kai Nacke + Martell re-posting.</div><div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">win64 seh clang is by Martell.</span><br></div></div><div><div>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px">mingw toolchain is by Martell.</span><br>
</div></div><div>register names is by <span style="font-size:12.727272033691406px;font-family:arial,sans-serif">Ray Donnelly + Martell posting it.</span><br></div><div>seh test for "register names" <font face="arial, sans-serif">( test is </font>r<span style="font-size:12.727272033691406px;font-family:arial,sans-serif">206566) by myself.</span><br>
</div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">All but the "register names" patch</span><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"> were posted by their author on the llvm lists.</span></div>
</div><div dir="ltr"><br></div><div dir="ltr">Yaron</div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"></div></div>
</blockquote></div>