[LLVMdev] Question about DAGCombiner::MatchRotate function

Tim Northover t.p.northover at gmail.com
Thu Oct 3 08:41:24 PDT 2013


Hi JinGu,

It's normally best to send patches to the llvm-commits list. That's
where most of the reviews happen.

> The problem is that code does not check this with new specific type "LArgVT"
> and "RArgVT" while processing above patterns. How do you think about this? I
> think checking code is needed.

I agree.

> I have attached simple patch to fix it. Please review this.

Which target does this affect (that you know of)? It would be really
good to have a test (like the other .ll files in test/CodeGen/XXX) for
this in the patch.

Cheers.

Tim.



More information about the llvm-dev mailing list