[LLVMdev] GCMetadataPrinter::finishAssembly not executed?

[Pedro Artigas]

HelloAll,

I am not an expert in CG but if the printer has to delete the info explicitly I believe any other client would have to do the same, I do not believe this has changed with Yiannis change.

Oh … true … there is that to delete too …

Pedro

On Feb 23, 2013, at 9:10 AM, Dmitry Babokin <babokin at gmail.com> wrote:

> Pedro, Yiannis,
> 
> What's about the usage case, when LLVM is used as a library and the user implements its custom pass, which dump the code (implemented as a FunctionPass, but not as Printer)?
> 
> You also missed in your changes the declaration of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h
> 
> -Dmitry.
> 
> On Mon, Feb 18, 2013 at 9:34 PM, Pedro Artigas <partigas at apple.com> wrote:
> 
> Hello Yiannis,
> 
> Your patch seems fine. It is option #2 which I am glad to hear solves the issue. It also removes more lines than it adds, I like patches that fix issues and have that property!
> 
> Anyhow if you add some testing, as you suggest, you should be good to go.
> 
> Thanks
> 
> Pedro
> 
> On Feb 16, 2013, at 6:13 AM, Yiannis Tsiouris <gtsiour at softlab.ntua.gr> wrote:
> 
> > <GCMetadata.patch>
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130225/3c51f2a3/attachment.html>