<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">HelloAll,<div><br></div><div>I am not an expert in CG but if the printer has to delete the info explicitly I believe any other client would have to do the same, I do not believe this has changed with Yiannis change.</div><div><br></div><div>Oh … true … there is that to delete too …</div><div><br></div><div>Pedro</div><div><br><div><div>On Feb 23, 2013, at 9:10 AM, Dmitry Babokin <<a href="mailto:babokin@gmail.com">babokin@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Pedro, Yiannis,<div><br></div><div>What's about the usage case, when LLVM is used as a library and the user implements its custom pass, which dump the code (implemented as a FunctionPass, but not as Printer)?</div><div>
<br></div><div>You also missed in your changes the declaration of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h<br><br>-Dmitry.</div><div><br><div class="gmail_quote">On Mon, Feb 18, 2013 at 9:34 PM, Pedro Artigas <span dir="ltr"><<a href="mailto:partigas@apple.com" target="_blank">partigas@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hello Yiannis,<br>
<br>
Your patch seems fine. It is option #2 which I am glad to hear solves the issue. It also removes more lines than it adds, I like patches that fix issues and have that property!<br>
<br>
Anyhow if you add some testing, as you suggest, you should be good to go.<br>
<br>
Thanks<br>
<br>
Pedro<br>
<br>
On Feb 16, 2013, at 6:13 AM, Yiannis Tsiouris <<a href="mailto:gtsiour@softlab.ntua.gr">gtsiour@softlab.ntua.gr</a>> wrote:<br>
<br>
> <GCMetadata.patch><br>
<div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu/" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></div></body></html>