[LLVMdev] Asking for a quick review

[Renato Golin]

On 3 April 2013 10:36, Tim Northover <t.p.northover at gmail.com> wrote:

> At the very least the change is subtle enough that I'd want a clear
> explanation in a nearby comment, I think. Hopefully that explanation
> can make it clear the patch is correct too.
>

+1


Also, there may be some misunderstanding about what's needed for a
> small test-case. I think what Bill was after is a small .ll test-case
> (as seen in test/CodeGen) which gets run whenever anyone runs "make
> check" and tests this feature. It would be committed alongside the
> change to the actual code.
>

At least make "check-all". Preferably the test-suite.

--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130403/d040f009/attachment.html>