<div dir="ltr">On 3 April 2013 10:36, Tim Northover <span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">At the very least the change is subtle enough that I'd want a clear<br>
explanation in a nearby comment, I think. Hopefully that explanation<br>
can make it clear the patch is correct too.<br></blockquote><div><br></div><div>+1</div><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Also, there may be some misunderstanding about what's needed for a<br>
small test-case. I think what Bill was after is a small .ll test-case<br>
(as seen in test/CodeGen) which gets run whenever anyone runs "make<br>
check" and tests this feature. It would be committed alongside the<br>
change to the actual code.<br></blockquote><div><br></div><div style>At least make "check-all". Preferably the test-suite.</div><div><br></div><div style>--renato<br></div></div></div></div>