[LLVMdev] [cfe-dev] is configure+make dead yet?

[Óscar Fuentes]

hume npx <humeafo at gmail.com> writes:

Sorry for commenting the bug report here, but I can't loging to bugzilla
right now.

> Using cmake should be the right thing if you'd like to support windows, but
> it seems that no enough effort on this build system, eg
> http://llvm.org/bugs/show_bug.cgi?id=12157 three months passed,

There is indeed a problem with the value assigned to
LLVM_TOOLS_BINARY_DIR in LLVMConfig.cmake.in because such value is valid
for an uninstalled build, but not for an installed one, because on
installing, LLVM_TOOLS_BINARY_DIR is not upated. As both build types
should be usable for clients, the solution is to detect in
LLVMConfig.cmake if it is being processed on an installed or uninstalled
build and assign LLVM_TOOLS_BINARY_DIR accordingly. This can be done,
for instance, comparing the values of CMAKE_CURRENT_LIST_FILE and
LLVM_INSTALL_PREFIX, with the necessary adjustments. Ditto for
LLVM_INCLUDE_DIRS and LLVM_LIB_DIRS.

The other two variables your patch touches (LLVM_INSTALL_PREFIX and
CMAKE_MODULE_PATH) does not need such corrections, as the former is
precisely the *intended* location for an installed build and the later
needs modification only for uninstalled builds, as the comment above the
IF hints.

Apart from that, your patch seems wrong for me because you are using
CMAKE_CURRENT_LIST_DIR. Such method only gives the desired result for
uninstalled, in-source builds.

> I'am I bit
> familiar with cmake, so if there tasks pending for absence of developer,
> I'd like to join.

Chandler is doing a great job at maintaining the CMake scripts, but I'm
sure he will welcome any help others can offer.

> cmake is not perfect but it's open, but many improvements maybe merged
> upstream.

[snip]