[LLVMdev] AddressSanitizer+CMake unittest question

[Kostya Serebryany]

On Wed, Jul 11, 2012 at 9:17 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Wed, Jul 11, 2012 at 10:03 AM, Kostya Serebryany <kcc at google.com>wrote:
>
>>
>>
>> On Wed, Jul 11, 2012 at 3:06 PM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>> And one more question regarding ASan cmake build.
>>> Currently unittests are fine, but regular "clang -faddress-sanitizer" is
>>> not:
>>>
>>
>> As a side note: I don't like that the current cmake machinery builds asan
>> tests by explicitly passing libclang_rt.asan-x86_64.a.
>> IMO it needs to use "clang -faddress-sanitizer".
>>
>
> Why?
>
> These are internal tests, and I think it is reasonable to use internal
> implementation details to make them work.
>

This complicates the maintenance (if we change the path
where libclang_rt.asan-x86_64.a resides we'' have to change it in two
places).
But as long as at least some tests actually use "clang
-faddress-sanitizer", it's not that critical if other tests
use libclang_rt.asan-x86_64.a

--kcc


>
> I'm not saying we can't get there, I think we can, but I think it may be
> somewhat more annoying than you might imagine to get there in the short
> term.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120711/f574b8e6/attachment.html>