[LLVMdev] git Status

Matthieu Moy Matthieu.Moy at grenoble-inp.fr
Wed Aug 24 06:14:29 PDT 2011


greened at obbligato.org (David A. Greene) writes:

>> b) We need a document explaining how patches are reviewed and referred
>> to, what commit rules (and hooks) are in place and how this would work
>> in a git world. It would be short and sweet.
>
> I'm not exactly sure what you're asking for.  My assumption is that the
> hooks in place for git are the same hooks we currently have for svn,
> ported to work with git.  Is there something else we need?

I don't really know LLVM's best practices, so I can't say exactly _what_
should go in such document, but I think it's important to distinguish
two things:

1) How one should behave wrt other LLVM developers, with rules like
   "please send patches this way" or "don't git push something that
   hasn't been reviewed before", or "here's how you may get a patch
   accepted if you're not an LLVM developer". It should also mention
   what happens on llvm.org, like "when you do a git push, here's what's
   going to happen".

2) Optionnaly, some technical hints on how to do 1) properly, like "if
   you're asked to send a revised version, git rebase -i and git commit
   --amend are your friends".

1) should be something people really agree on, and it people want it to
be as close as possible to the existing flow. 2) is a matter of
personnal choice (advanced Git users won't need to read it).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/



More information about the llvm-dev mailing list