[LLVMdev] Win32 COFF Support

[Samuel Crow]

Hi Nathan,

According to http://llvm.org//docs/CodingStandards.html#hl_dontinclude you seem to be right on this one.  If this isn't what the team leaders meant, they shouldn't have written it as it is.

--Sam


>
>From: Nathan Jeffords <blunted2night at gmail.com>
>To: Eli Friedman <eli.friedman at gmail.com>
>Cc: LLVM Dev <llvmdev at cs.uiuc.edu>
>Sent: Thu, May 20, 2010 11:43:30 AM
>Subject: Re: [LLVMdev] Win32 COFF Support
>
>
>
>
>>>6.
>>>>+namespace llvm { MCObjectWriter * createWinCOFFObjectWriter
>>>>(raw_ostream & OS); }
>>
>>>>If you need a function to be visible across files, use a header;
>>>>shortcuts like this make the code more difficult to read.
>>
>>
> 
>On this one, it didn't seem appropriate to include WinCOFFObjectWriters header into X86AsmBackend, it also seems to be overkill to add a header to contain a single function. I would like some more feedback on what the sanctioned course of action should be here. 
>
>- Nathan


      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100521/865f55fe/attachment.html>