<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman,new york,times,serif;font-size:12pt"><div>Hi Nathan,<br><br><span>According to <a target="_blank" href="http://llvm.org//docs/CodingStandards.html#hl_dontinclude">http://llvm.org//docs/CodingStandards.html#hl_dontinclude</a> you seem to be right on this one. If this isn't what the team leaders meant, they shouldn't have written it as it is.</span><br><br>--Sam<br></div><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;"><br><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;"><font face="Tahoma" size="2"><b><span style="font-weight: bold;">From:</span></b> Nathan Jeffords <blunted2night@gmail.com><br><b><span style="font-weight: bold;">To:</span></b> Eli Friedman
<eli.friedman@gmail.com><br><b><span style="font-weight: bold;">Cc:</span></b> LLVM Dev <llvmdev@cs.uiuc.edu><br><b><span style="font-weight: bold;">Sent:</span></b> Thu, May 20, 2010 11:43:30 AM<br><b><span style="font-weight: bold;">Subject:</span></b> Re: [LLVMdev] Win32 COFF Support<br></font><br>
<meta http-equiv="x-dns-prefetch-control" content="off"><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
6.<br>
+namespace llvm { MCObjectWriter * createWinCOFFObjectWriter<br>
(raw_ostream & OS); }<br>
<br>
If you need a function to be visible across files, use a header;<br>
shortcuts like this make the code more difficult to read.<br>
<font color="#888888"><br></font></blockquote><div> </div><div>On this one, it didn't seem appropriate to include WinCOFFObjectWriters header into X86AsmBackend, it also seems to be overkill to add a header to contain a single function. I would like some more feedback on what the sanctioned course of action should be here. </div>
<div></div></div><br><div>- Nathan</div>
<meta http-equiv="x-dns-prefetch-control" content="on"></div></div></blockquote>
</div><br>
</body></html>