[LLVMdev] [PATCH]: MSVC build enhancements

[José Fonseca]

On Sat, Mar 6, 2010 at 11:33 AM, Cédric Venet <cedric.venet at laposte.net> wrote:
> Le 06/03/2010 11:43, José Fonseca a écrit :
>>
>> Attached are two patches with MSVC build enchancements.
>>
>> They are quite trivial, but were necessary to correctly link LLVM
>> libraries with Mesa3D on Windows.
>>
>> Jose
>>
>
> Are you volontary trying to break everyone build (just to build your own
> project), or have you no idea of the effect of this change:
>
> +add_llvm_definitions( -D_SECURE_SCL=0 )
>
> While I personnaly use this flag in all my projects, it should not be
> silently and sneakily imposed to all llvm user. You should make it an
> option, and keep the default as it is currently. I.e. make this an opt-in
> choice.
>
> While I may seem harsh, this flag change the ABI !!! and its effects are
> very hard to understand and debug. For me it is criminal to try to pass this
> as a "trivial" patch. (already been bitten here)

I had these changes locally for many months now and thought it might
be useful to others so decided to submit them before 2.7. I have no
vested interested in them for my project as I always build llvm
myself.

That flag was suggested in some website to solve issues when
statically linking release LLVM libraries in a debug build. I had no
idea of the full implications, nor can I really deduct from your reply
how deep they are, but I'll investigate it further.

It was not my intention to break things. To be honest the whole
process of statically linking libraries in MSVC is full of flaws and
is not a little bit robust, so I don't get surprised with anything
anymore.

So feel free to ignore the chunk or the whole patch, or the whole set.

Jose