[LLVMdev] [PATCH]: MSVC build enhancements

[Cédric Venet]

Le 06/03/2010 11:43, José Fonseca a écrit :
> Attached are two patches with MSVC build enchancements.
>
> They are quite trivial, but were necessary to correctly link LLVM
> libraries with Mesa3D on Windows.
>
> Jose
>    
>

Are you volontary trying to break everyone build (just to build your own 
project), or have you no idea of the effect of this change:

+add_llvm_definitions( -D_SECURE_SCL=0 )

While I personnaly use this flag in all my projects, it should not be 
silently and sneakily imposed to all llvm user. You should make it an 
option, and keep the default as it is currently. I.e. make this an 
opt-in choice.

While I may seem harsh, this flag change the ABI !!! and its effects are 
very hard to understand and debug. For me it is criminal to try to pass 
this as a "trivial" patch. (already been bitten here)

regards,
Cédric