[LLVMdev] RFC: Criteria for backing out patches

[Chris Lattner]

On Jun 15, 2010, at 7:12 AM, Gabor Greif wrote:

> Hi all,
> 
> looks like the WWDC has been a nice success, but
> it is over now and all devs are back to normal mode.
> 
> I have written up a very subjective blog post here
> 
> <http://heisenbug.blogspot.com/2010/06/my-grief-with-out-of-tree-code.html>
> 
> in which I ask for clarifications to the development
> policy wrt. backing out of buildbot-proven patches
> because of (unintended) breakage in external projects.
> 
> It mostly amounts to how devs can cooperate to advance
> the fundamental status quo regarding code quality in the
> framework (i.e. the LLVM libs) and its clients (e.g.
> Apple's OpenGL stack).
> 
> As you see this is a somewhat nagging need in me and
> I would love to converge towards a satisfying solution.

Hi Gabor,

I saw your post and completely agree with you.  Your patch should go in based on its own merits, if there is out of tree code that breaks, it isn't your fault or problem.

-Chris