[LLVMdev] RegisterScavenging on targets without subregisters

[Scott Michel]

Kalle:

Your patch is similar to what I'd coded (and am testing, which means a
couple of hours before I consider committing). Other than cosmetic changes
and changing 'NULL' to '0' (it's an integer list, after all). This patch now
causes new problems in the CellSPU backend (more stqd's and lqd's), so I
have to investigate those before committing the patch.

'make test' is our friend. 'make test' is our friend. 'make test' is our
friend. :-)


-scooter

On Thu, Feb 25, 2010 at 11:25 PM, <Kalle.Raiskila at nokia.com> wrote:

>
> Scott Michel skrev:
> > No, I wasn't having a management lobotomy moment. If the target's
> registers have
> > no subregisters, SubUsed is false and the assert gets tripped.
> >
> > Ok, back to the original question: What was the original intent in this
> code
> > (lines 186-193 in lib/CodeGen/RegisterScavenging.cpp)?
>
> You beat me to it :). A simple bypass (patch attached) does at least not
> break 'make check' with x86 and SPU backends. (And fixes the problem
> with call.ll-test breaking when the SPU bigframes patch is applied)
>
> kalle
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100226/f9dee0a0/attachment.html>